From e13b3203990706db1313ec2aadd9a30b249ee793 Mon Sep 17 00:00:00 2001 From: Andrew Cooper Date: Fri, 22 Aug 2014 14:32:45 +0200 Subject: [PATCH] x86/irq: process softirqs in irq keyhandlers Large machines with lots of interrupts can trip over the Xen watchdog. Suggested-by: Santosh Jodh Signed-off-by: Andrew Cooper Tested-by: Santosh Jodh --- xen/arch/x86/io_apic.c | 10 ++++++++++ xen/arch/x86/irq.c | 4 ++++ 2 files changed, 14 insertions(+) diff --git a/xen/arch/x86/io_apic.c b/xen/arch/x86/io_apic.c index 4e6fe2bd7e..1b576365dd 100644 --- a/xen/arch/x86/io_apic.c +++ b/xen/arch/x86/io_apic.c @@ -28,6 +28,7 @@ #include #include #include +#include #include #include #include @@ -1112,6 +1113,8 @@ static void /*__init*/ __print_IO_APIC(void) printk(KERN_INFO "testing the IO APIC.......................\n"); for (apic = 0; apic < nr_ioapics; apic++) { + process_pending_softirqs(); + if (!nr_ioapic_entries[apic]) continue; @@ -1215,6 +1218,10 @@ static void /*__init*/ __print_IO_APIC(void) printk(KERN_DEBUG "IRQ to pin mappings:\n"); for (i = 0; i < nr_irqs_gsi; i++) { struct irq_pin_list *entry = irq_2_pin + i; + + if ( !(i & 0x1f) ) + process_pending_softirqs(); + if (entry->pin < 0) continue; printk(KERN_DEBUG "IRQ%d ", irq_to_desc(i)->arch.vector); @@ -2454,6 +2461,9 @@ void dump_ioapic_irq_info(void) for ( irq = 0; irq < nr_irqs_gsi; irq++ ) { + if ( !(irq & 0x1f) ) + process_pending_softirqs(); + entry = &irq_2_pin[irq]; if ( entry->pin == -1 ) continue; diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c index dafd33843c..f214072405 100644 --- a/xen/arch/x86/irq.c +++ b/xen/arch/x86/irq.c @@ -19,6 +19,7 @@ #include #include #include +#include #include #include #include @@ -2234,6 +2235,8 @@ static void dump_irqs(unsigned char key) for ( irq = 0; irq < nr_irqs; irq++ ) { + if ( !(irq & 0x1f) ) + process_pending_softirqs(); desc = irq_to_desc(irq); @@ -2287,6 +2290,7 @@ static void dump_irqs(unsigned char key) xfree(ssid); } + process_pending_softirqs(); printk("Direct vector information:\n"); for ( i = FIRST_DYNAMIC_VECTOR; i < NR_VECTORS; ++i ) if ( direct_apic_vector[i] ) -- 2.30.2